Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin Go version to 1.20.5 #4021

Closed
wants to merge 1 commit into from
Closed

pin Go version to 1.20.5 #4021

wants to merge 1 commit into from

Conversation

tonistiigi
Copy link
Member

Go 1.20.6 broke many tools (eg. Buildx). Better to be on the safe side and pin 1.20.5 until the full extent is determined/resolved.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@tonistiigi
Copy link
Member Author

tonistiigi commented Jul 12, 2023

I tested that buildctl with unix:// address seems to work fine. And container connhelper does direct docker exec https://github.com/moby/buildkit/blob/master/client/connhelper/dockercontainer/dockercontainer.go#L32 instead of using Docker client. So we might be fine.

Refs:
moby/moby#45935
https://github.com/moby/moby/pull/45942/files
golang/go#61076

The downside of pinning would be that some security scanner could pick up the new release as vulnerable from the start.

@tonistiigi
Copy link
Member Author

With further investigation, we haven't found a case that is breaking. Looks like HTTP2 part of the patch was not backported and we don't create HTTP1 connections over Unix sockets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants