ci(deps): upgrade OpenTelemetry to v1.19.0 / v0.45.0 #4424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milas
force-pushed
the
v0.12-otel-1.19
branch
from
63bd992
to
a430cc3
Compare
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
milas
force-pushed
the
v0.12-otel-1.19
branch
from
a430cc3
to
7beb053
Compare
|
Not sure why you didn't just update #4318? I don't think we want this for 0.12. |
3 tasks
|
@milas hope it's ok if I close this - agreed with @crazy-max that we probably shouldn't take this for 0.12 (since it also requires a containerd upgrade, and doing this in patch releases is not really desirable). If there's some discussion I've missed, we can re-open as a cherry-pick of #4318. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using HEAD of the 1.7 branch of containerd: containerd/containerd@bb0e42a
Will rebase and remove from draft when there's a stable 1.7.x containerd release that includes the v1.19 OTel deps.
In the meantime, this PR can help get a jumpstart on finding integration issues (if any) from CI.