Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: add source location to circular dependency error #4567

Merged
merged 2 commits into from Jan 19, 2024

Conversation

tonistiigi
Copy link
Member

Update the detection and handling of circular dependency validation.

New output:

# buildctl build --frontend dockerfile.v0 --local context=. --local dockerfile=.
[+] Building 0.0s (1/1) FINISHED
 => [internal] load build definition from Dockerfile                                                                           0.0s
 => => transferring dockerfile: 197B                                                                                           0.0s
Dockerfile:9
--------------------
   7 |
   8 |     FROM alpine AS build
   9 | >>> COPY --from=target /Dockerfile /d2
  10 |
  11 |     FROM target
--------------------
Dockerfile:3
--------------------
   1 |
   2 |     FROM busybox AS target
   3 | >>> COPY --from=build / /out
   4 |
   5 |     FROM target as b
--------------------
error: failed to solve: circular dependency detected on stage: target

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Copy link
Member Author

@AkihiroSuda Looks like the detachnetns testsuite is causing timeouts?

@AkihiroSuda
Copy link
Member

@AkihiroSuda Looks like the detachnetns testsuite is causing timeouts?

Green after restarting.
We have to deflake it though, if its flakiness arises from detach-netns.

@AkihiroSuda AkihiroSuda merged commit ec61614 into moby:master Jan 19, 2024
64 checks passed
@AkihiroSuda AkihiroSuda added this to the v0.13.0 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants