Add --chown and --chmod to commitMessage for ADD/COPY command #4597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nobi <nobi@nobidev.com>
jedevc
reviewed
Jan 30, 2024
Comment on lines
+1158
to
+1164
| if cfg.chown != "" { | ||
| commitMessage.WriteString(" " + "--chown=" + cfg.chown) | ||
| } | ||
| if cfg.chmod != "" { | ||
| commitMessage.WriteString(" " + "--chmod=" + cfg.chmod) | ||
| } | ||
|
|
There was a problem hiding this comment.
If we apply this change, we should make sure to cover all the flags that these support. --from, --parents, --checksum, etc.
There was a problem hiding this comment.
--parents: is reasonable
--from: I think it's not necessary (because images only includes the last stage, so adding from doesn't help)
--checksum: Checksum is usually quite long. So I think including it will make the history look more confusing?
Signed-off-by: Nobi <nobi@nobidev.com>
jedevc
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the commit message of the COPY/ADD command should include chown/chmod information for clarity.