gha: add support for batch checking existing keys #4788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid getting rate limited when checking if previous cache already exists use the Github REST API that supports listing active keys. This means additional GITHUB_TOKEN access is also needed in addition to the RUNTIME_TOKEN needed for the cache API. The implementation is done with a fallback - if GITHUB_TOKEN is passed then it is used, if not then the old method checking individual cache records is still used. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
LGTM
Note for myself to have a follow-up in https://github.com/docker/actions-toolkit to set new attributes automatically when gha cache is used.
Comment on lines
+130
to
+132
| func (ce *exporter) blobKeyPrefix() string { | ||
| return "buildkit-blob-" + version + "-" | ||
| } |
crazy-max
reviewed
May 31, 2024
Comment on lines
+40
to
+41
| attrRepository = "repository" | ||
| attrGHToken = "ghtoken" |
There was a problem hiding this comment.
needs docs updates in https://github.com/moby/buildkit?tab=readme-ov-file#github-actions-cache-experimental and https://docs.docker.com/build/cache/backends/gha/ to define these new attributes (cc @dvdksn)
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid getting rate limited when checking if previous cache already exists use the Github REST API that supports listing active keys.
This means additional GITHUB_TOKEN access is also
needed in addition to the RUNTIME_TOKEN needed for the cache API. The implementation is done with a fallback - if GITHUB_TOKEN is passed then it is used, if not then the old method checking individual cache records is still used.
Depends on tonistiigi/go-actions-cache#19