inline: fix uncompressed digest importing from multiple providers #4796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Moby adapters are used without containerd backend, the descriptors are lacking the original compressed layer digest and there is a workaround to link in the uncompressed digest. If a build exporting the cache also imported it from the registry then the original imported records with compressed digest needs to be exported as well. If there were another exported records that referred to the same layers via the uncompressed digest through parent layers then such records could be overwritten and the original provider from cache import could get lost. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
approved these changes
Mar 26, 2024
|
@tonistiigi raising also here for visibility (asked in discussions as well) - is there an ETA for when this could land in a release? Either 0.14 or 0.13.3 (I personally think it warrants a cherry pick and a patch release just for this). Thanks! |
|
This is coming in 0.14 (rc eta next Friday). The patch can also be ported over to Moby directly without buildkit update. As it doesn't directly affect buildkitd then no 0.13.3 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2274
When Moby adapters are used without containerd backend, the descriptors are lacking the original compressed layer digest and there is a workaround to link in the uncompressed digest. If a build exporting the cache also imported it from the registry then the original imported records with compressed digest needs to be exported as well. If there were another exported records that referred to the same layers via the uncompressed digest through parent layers then such records could be overwritten and the original provider from cache import could get lost.