-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort lint warning output and make consistent #4852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w consistent Signed-off-by: Talon Bowler <talon.bowler@docker.com>
tonistiigi
reviewed
Apr 16, 2024
…nings we receive from the lint subrequest Signed-off-by: Talon Bowler <talon.bowler@docker.com>
tonistiigi
reviewed
Apr 17, 2024
02e3b49
to
53e42ff
Compare
tonistiigi
reviewed
Apr 17, 2024
97b5756
to
a44d79e
Compare
tonistiigi
reviewed
Apr 17, 2024
a44d79e
to
7c1aadb
Compare
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
7c1aadb
to
04d85f3
Compare
tonistiigi
approved these changes
Apr 17, 2024
crazy-max
approved these changes
Apr 17, 2024
@tonistiigi or @crazy-max Merge? 😮 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4844
This is a follow-up to #4761, and updates the printed source map for the lint warnings to be consistent with how they are displayed when viewing them via the
docker --debug
flag.Old:
New: