Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort lint warning output and make consistent #4852

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

daghack
Copy link
Collaborator

@daghack daghack commented Apr 16, 2024

fixes #4844

This is a follow-up to #4761, and updates the printed source map for the lint warnings to be consistent with how they are displayed when viewing them via the docker --debug flag.

Old:

Lint Rule StageNameCasing
  Dockerfile:2
  Lint Rule 'StageNameCasing': Stage name 'buildER' should be lowercase (line 2)
  2  |  FROM $BASE:1.20-alpine AS buildER

New:

- Lint Rule 'StageNameCasing': Stage name 'buildER' should be lowercase (line 2)
Stage names should be lowercase
Dockerfile:2
--------------------
   1 |     ARG BASE=golang
   2 | >>> FROM $BASE:1.20-alpine AS buildER
   3 |
   4 |     WOrkdIR /go/src/github.com/restic/restic
--------------------

…w consistent

Signed-off-by: Talon Bowler <talon.bowler@docker.com>
@daghack daghack self-assigned this Apr 16, 2024
frontend/subrequests/lint/lint.go Outdated Show resolved Hide resolved
frontend/subrequests/lint/lint.go Outdated Show resolved Hide resolved
…nings we receive from the lint subrequest

Signed-off-by: Talon Bowler <talon.bowler@docker.com>
frontend/subrequests/lint/lint.go Outdated Show resolved Hide resolved
frontend/subrequests/lint/lint.go Outdated Show resolved Hide resolved
@daghack daghack force-pushed the consistent-sourcemap-print branch 2 times, most recently from 02e3b49 to 53e42ff Compare April 17, 2024 03:41
frontend/subrequests/lint/lint.go Outdated Show resolved Hide resolved
frontend/subrequests/lint/lint.go Outdated Show resolved Hide resolved
@daghack daghack force-pushed the consistent-sourcemap-print branch 2 times, most recently from 97b5756 to a44d79e Compare April 17, 2024 12:48
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
@daghack
Copy link
Collaborator Author

daghack commented Apr 17, 2024

@tonistiigi or @crazy-max Merge? 😮 Thank you!

@tonistiigi tonistiigi merged commit 71f99c5 into moby:master Apr 17, 2024
73 checks passed
@daghack daghack deleted the consistent-sourcemap-print branch April 17, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update print=lint output format to be consistent with existing warning output.
3 participants