dockerfile: add lint rule for maintainer instruction #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsternberg
force-pushed
the
maintainer-lint-rule
branch
2 times, most recently
from
98ddfb6
to
3197f85
Compare
tonistiigi
reviewed
Apr 24, 2024
| @@ -80,6 +80,9 @@ func ParseInstructionWithLinter(node *parser.Node, lintWarn linter.LintWarnFunc) | |||
| case command.Env: | |||
| return parseEnv(req) | |||
| case command.Maintainer: | |||
| if lintWarn != nil { | |||
There was a problem hiding this comment.
I wonder if we could just have this nil check inside the Run() one time so every caller does not need to check it.
| @@ -41,4 +41,12 @@ var ( | |||
| return fmt.Sprintf("Command '%s' should match the case of the command majority (%s)", violatingCommand, correctCasing) | |||
| }, | |||
| } | |||
| RuleMaintainerDeprecated = LinterRule[func() string]{ | |||
| Name: "MaintainerDeprecated", | |||
| Description: "The maintainer instruction is deprecated and will generate an error in future versions of the Dockerfile syntax", | |||
There was a problem hiding this comment.
nit: Because we can't actually remove instructions without v2, maybe "The maintainer instruction is deprecated, use a label instead to define image author."
jsternberg
force-pushed
the
maintainer-lint-rule
branch
from
3197f85
to
d2e2607
Compare
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
maintainer-lint-rule
branch
from
d2e2607
to
79f66ec
Compare
daghack
approved these changes
Apr 24, 2024
tonistiigi
approved these changes
Apr 24, 2024
profnandaa
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.