update lint subrequest to return build error #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daghack
force-pushed
the
return-lint-warnings-after-build-err
branch
from
d635c7e
to
809f083
Compare
daghack
force-pushed
the
return-lint-warnings-after-build-err
branch
2 times, most recently
from
cc152a7
to
ac9e7ca
Compare
tonistiigi
reviewed
Apr 29, 2024
daghack
force-pushed
the
return-lint-warnings-after-build-err
branch
from
ac9e7ca
to
84d926e
Compare
… rather than a failed grpc response Signed-off-by: Talon Bowler <talon.bowler@docker.com>
daghack
force-pushed
the
return-lint-warnings-after-build-err
branch
from
84d926e
to
438f30f
Compare
tonistiigi
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
lintsubrequest so that in the case of encountering a build error, it can return the lint warnings which occurred up to that point as well as the error message and source location where the error occurred.It also updates tests, refactoring a bit to better accommodate for the increasing number of parameters to the
checkLinterWarningsfunction.