Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add undefined arg lint rule #4897

Merged
merged 3 commits into from
May 11, 2024
Merged

Add undefined arg lint rule #4897

merged 3 commits into from
May 11, 2024

Conversation

daghack
Copy link
Collaborator

@daghack daghack commented May 2, 2024

This adds a lint rule that warns when an $VARIABLE inside a dockerfile is unmatched within the context of the command.

@daghack daghack marked this pull request as draft May 2, 2024 14:54
@daghack daghack force-pushed the undeclared-args branch 6 times, most recently from 39e7ce6 to a865a74 Compare May 2, 2024 16:57
@daghack daghack marked this pull request as ready for review May 2, 2024 17:24
@daghack daghack requested a review from tonistiigi May 2, 2024 17:24
frontend/dockerfile/dockerfile2llb/convert.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile2llb/convert.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_lint_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_lint_test.go Outdated Show resolved Hide resolved
@daghack daghack marked this pull request as draft May 2, 2024 18:33
@daghack daghack force-pushed the undeclared-args branch 6 times, most recently from 7f32856 to 5a3351e Compare May 3, 2024 04:44
@daghack daghack marked this pull request as ready for review May 6, 2024 14:41
frontend/dockerfile/dockerfile2llb/convert.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_lint_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile2llb/convert.go Outdated Show resolved Hide resolved
@daghack daghack marked this pull request as draft May 8, 2024 00:08
@daghack daghack force-pushed the undeclared-args branch 4 times, most recently from 0a8fde3 to 8cb40e7 Compare May 8, 2024 04:18
@daghack daghack marked this pull request as ready for review May 8, 2024 14:35
frontend/dockerfile/dockerfile2llb/convert.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile2llb/convert.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile2llb/convert.go Outdated Show resolved Hide resolved
@daghack daghack force-pushed the undeclared-args branch 2 times, most recently from 31dc10f to ecdb4c3 Compare May 9, 2024 16:02
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
…test cases

Signed-off-by: Talon Bowler <talon.bowler@docker.com>
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
@tonistiigi tonistiigi merged commit 4f2ebdd into moby:master May 11, 2024
73 checks passed
@daghack daghack deleted the undeclared-args branch May 13, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants