linter: add rule for relative path used in workdir #4903
Conversation
jsternberg
force-pushed
the
lint-workdir-relative-path
branch
2 times, most recently
from
f9fde2f
to
041e58d
Compare
| @@ -1124,6 +1126,8 @@ func dispatchRun(d *dispatchState, c *instructions.RunCommand, proxy *llb.ProxyE | |||
| } | |||
|
|
|||
| func dispatchWorkdir(d *dispatchState, c *instructions.WorkdirCommand, commit bool, opt *dispatchOpt) error { | |||
| //validateWorkdir(c, d.image.Config.WorkingDir, d.platform.OS, opt.lintWarn) | |||
jsternberg
force-pushed
the
lint-workdir-relative-path
branch
3 times, most recently
from
2ec81de
to
e8e0895
Compare
|
This is passing tests but I'm not sure if this implementation is the best way to go about this. There's something about the if statement for |
| // checking the base image. | ||
| if system.IsAbs(c.Path, d.platform.OS) { | ||
| d.absWorkdirSet = true | ||
| } else if !d.absWorkdirSet { |
There was a problem hiding this comment.
I think showing this only on first relative WORKDIR would be fine as that is the only line that would need to be fixed. So that means d.absWorkdirSet = true in all cases.
There was a problem hiding this comment.
Considering this comment, I modified the code a bit to make it a bit more clear. It still uses commit to determine whether to run the lint, but I've changed the variable to workdirSet instead and had it unconditionally set to true. I think this is ready to be reviewed and merged if approved now.
jsternberg
force-pushed
the
lint-workdir-relative-path
branch
from
e8e0895
to
ae6a1cb
Compare
jsternberg
force-pushed
the
lint-workdir-relative-path
branch
from
ae6a1cb
to
a346644
Compare
Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
lint-workdir-relative-path
branch
from
a346644
to
218ce96
Compare
No description provided.