Add Lint Controls #4962
Merged
Add Lint Controls #4962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daghack
force-pushed
the
lint-skip
branch
4 times, most recently
from
7df288f
to
75d1f1f
Compare
tonistiigi
reviewed
May 29, 2024
| @@ -13,12 +13,14 @@ import ( | |||
|
|
|||
| const ( | |||
| keySyntax = "syntax" | |||
| keyCheck = "check" | |||
There was a problem hiding this comment.
@colinhemmings I'm not sure if "check" works in here.
#syntax=docker/dockerfile
#check=skip=StageNameCasing
FROM alpine
There was a problem hiding this comment.
I've made a comment on the proposal related that rule would be a better term to use here
daghack
force-pushed
the
lint-skip
branch
15 times, most recently
from
3ddfca2
to
4216f7c
Compare
daghack
force-pushed
the
lint-skip
branch
2 times, most recently
from
7f1f006
to
86eb9be
Compare
daghack
force-pushed
the
lint-skip
branch
7 times, most recently
from
3e4e01b
to
6f2e67d
Compare
tonistiigi
reviewed
May 31, 2024
tonistiigi
reviewed
May 31, 2024
tonistiigi
reviewed
May 31, 2024
daghack
force-pushed
the
lint-skip
branch
2 times, most recently
from
30807ff
to
0a29cdf
Compare
tonistiigi
reviewed
May 31, 2024
| @@ -162,6 +162,67 @@ func ListTargets(ctx context.Context, dt []byte) (*targets.List, error) { | |||
| return l, nil | |||
| } | |||
|
|
|||
| func parseLintOptions(checkStr string) (*linter.Config, error) { | |||
There was a problem hiding this comment.
In future I think this can be moved to public function in linter pkg (and called both from here in dockerui) but that can be changed in some follow-up PR.
tonistiigi
reviewed
May 31, 2024
daghack
force-pushed
the
lint-skip
branch
3 times, most recently
from
be11de7
to
593dc8e
Compare
tonistiigi
reviewed
May 31, 2024
tonistiigi
reviewed
May 31, 2024
tonistiigi
approved these changes
May 31, 2024
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements most of #4919 (the
check-skipdirective for skipping a specific is omitted as follow up work in a forthcoming PR)