allow skipping backlinks where walking cache chains for provenance #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backlink walking should not be needed to determine layers for current build and should be safe to skip. This improves performance of provenance creation for certain builds. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
ktock
approved these changes
May 31, 2024
AkihiroSuda
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4942
Backlink walking should not be needed to determine layers for current build and should be safe to skip. This improves performance of provenance creation for certain builds.
I consider this only a quick mitigation. It seems likely that there is an issue with walking all cache chains on export that shows up on specific builds that needs further investigation.