Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: add docker:// connhelper #904

Merged
merged 3 commits into from
Mar 26, 2019
Merged

client: add docker:// connhelper #904

merged 3 commits into from
Mar 26, 2019

Conversation

AkihiroSuda
Copy link
Member

Usage:

$ docker run -d --name buildkit-rootless --security-opt seccomp=unconfined --security-opt apparmor=unconfined moby/buildkit:local-rootless --oci-worker-no-process-sandbox
$ export BUILDKIT_HOST=docker://buildkit-rootless
$ buildctl build ...

Part of #769
kubepod+experimental:// helper will be also added later.

@AkihiroSuda AkihiroSuda mentioned this pull request Mar 25, 2019
Closed
tonistiigi
tonistiigi reviewed Mar 26, 2019
View reviewed changes
hack/dockerfiles/test.Dockerfile
@@ -188,6 +188,7 @@ ENV HOME /home/user
ENV USER user
ENV XDG_RUNTIME_DIR=/run/user/1000
ENV TMPDIR=/home/user/.local/tmp
ENV BUILDKIT_HOST=unix:///run/user/1000/buildkit/buildkitd.sock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this required now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker exec -i bk-rootless buildctl dial-stdio needs valid BUILDKIT_HOST to be set in the bk-rootless container

tonistiigi
tonistiigi reviewed Mar 26, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
@AkihiroSuda
buildctl: add dial-stdio (for unix:// address only)
832d025 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@AkihiroSuda
client: add docker:// connhelper
2f007a4 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@AkihiroSuda
test.Dockerfile: set BUILDKIT_HOST for rootless image
1795cfa 
Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
@tonistiigi tonistiigi merged commit 6a94f95 into moby:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonistiigi tonistiigi tonistiigi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AkihiroSuda @tonistiigi