Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better plain mode progress #919

Merged
merged 4 commits into from
Apr 3, 2019
Merged

better plain mode progress #919

merged 4 commits into from
Apr 3, 2019

Conversation

tonistiigi
Copy link
Member

Improve plain progress readability, example: https://gist.github.com/tonistiigi/8a5af70c4e54bfb8b894d40b3d86321c

fixes #863

@tonistiigi
progressui: improve plain progress
d451b66 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
progressui: print error again on plain mode
770dbc8 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
buildctl: print plain progress to stderr
5223dc7 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
progressui: allow unclipped output with env
e1d2033 
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tiborvass
tiborvass approved these changes Apr 3, 2019
View reviewed changes
Copy link
Collaborator

@tiborvass tiborvass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, this is awesome. Outputs will be so much better!

@tiborvass tiborvass merged commit 685ed3e into moby:master Apr 3, 2019
@databus23 databus23 mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiborvass tiborvass tiborvass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress is redirected to output on Travis-CI
2 participants
@tonistiigi @tiborvass