Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First class windows support #85

Closed
djs55 opened this issue May 3, 2016 · 8 comments
Closed

First class windows support #85

djs55 opened this issue May 3, 2016 · 8 comments

Comments

@djs55
Copy link
Collaborator

djs55 commented May 3, 2016

I need to make a datakit server which

  • has logging customised for Windows (probably though a custom log reporter)
  • listens on a named pipe
  • listens on Hyper-V sockets
  • is built on Windows in CI (e.g. on Appveyor)

What do you think is the best approach?

@samoht
Copy link
Member

samoht commented May 3, 2016

I can have a look if you want. I'll start by adding an appveyor file.

How do you listen for Hyper-V sockets? Can you listen on named pipes with the Unix library?

@djs55
Copy link
Collaborator Author

djs55 commented May 3, 2016

That would be awesome, thanks!

@yomimono and I are investigating named pipes. Normal OCaml doesn't support them, although ocamlnet does. I've started hacking on [djs55/ocaml-namedpipe].

I think Hyper-V sockets will be similar -- probably once we've got named pipes then adding Hyper-V sockets will be ok.

@djs55
Copy link
Collaborator Author

djs55 commented May 3, 2016

BTW I've got most of the code in piñata building on Windows with camlp4 -- in some cases I back ported windows fixes to before the ppx rewrite. Does datakit prefer camlp4 or ppx?

@samoht
Copy link
Member

samoht commented May 3, 2016

datakit uses cppo for optional compilation, but no other pre-processor stuff.

@samoht
Copy link
Member

samoht commented May 3, 2016

I've also compiled a version of datakit on Windows (it was 0.2.0 I think). I'll check that it still compiles and allow ways to do optionally compile more stuff in.

@samoht
Copy link
Member

samoht commented May 3, 2016

has logging customised for Windows (probably though a custom log reporter)

Do you know which logging framework do you want to use on Windows? The current default logger just uses stdout.

@djs55
Copy link
Collaborator Author

djs55 commented May 3, 2016

Actually stdout will probably work ok for now.

@samoht
Copy link
Member

samoht commented May 23, 2016

Closing this as datakit works now well on windows.

@samoht samoht closed this as completed May 23, 2016
avsm pushed a commit to avsm/datakit that referenced this issue Jan 19, 2017
packages for the TLS release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants