ci: add support for getting X.509 certificates via certbot #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a quick hack. It adds a script that you can run to update the certificates. It works because certbot actually only needs to run on port 80 and so doesn't need to disturb the CI. I've used this to move the server's official name from datakit.ci:8446 to datakit.datakit.ci. This PR also makes some improvements to the form system because I originally had a web UI for this, but they seemed worth keeping anyway. There are many ways it could be improved: - Don't require the server to be restarted to use the new certificate. - Run the script automatically when the certificate is due to expire. - Report a metric saying how long the current certificate is valid for. Signed-off-by: Thomas Leonard <thomas.leonard@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick hack. It adds a script that you can run to update
the certificates. It works because certbot actually only needs to run on
port 80 and so doesn't need to disturb the CI.
I've used this to move the server's official name from datakit.ci:8446
to datakit.datakit.ci.
This PR also makes some improvements to the form system because I
originally had a web UI for this, but they seemed worth keeping anyway.
There are many ways it could be improved: