[WIP] Change meaning of UUID field, add VPNKitKey field #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
changed the title
ijc
reviewed
Apr 12, 2017
go/hyperkit.go
Outdated
| @@ -69,7 +69,9 @@ type HyperKit struct { | |||
| StateDir string `json:"state_dir"` | |||
| // VPNKitSock is the location of the VPNKit socket used for networking. | |||
| VPNKitSock string `json:"vpnkit_sock"` | |||
| // UUID is a string containing a UUID for the VM. It can be used in conjunction with VPNKit to get consistent IP address. | |||
| // VPNKitKey is a string containing a UUID, it can be used in conjunction with VPNKit to get consistent IP address. | |||
| VPNKitKey string `json:"uuid"` | |||
There was a problem hiding this comment.
json should be vpnkit_key I think. No idea what happens with the duplicated names!
There was a problem hiding this comment.
Thanks, I've missed that!
We have missused UUID filed for VPNKit, and not the `-U` flag which it naturally maps to.
justincormack
approved these changes
Apr 12, 2017
|
LGTM, these bindings are pretty new so no need to worry about making breaking just yet. In the future it might be nice to generate a UUID if the caller doesn't supply one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have missused UUID filed for VPNKit, and not the
-Uflag which it naturally maps to.It seems reasonably to leave it up to the caller how they wish to generate UUIDs.
This is a breaking change, hence I marked it WIP (so it doesn't gets merged too soon), and the biggest question question is how should we communicate this change to those who depend on these bindings?