Avoid persisting ipam data if it can be reconstructed #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@aboch Thanks for adding the capability for the remote drivers |
- Also restore older behavior where overlap check is not run when preferred pool is specified. Got broken by recent changes Signed-off-by: Alessandro Boch <aboch@docker.com>
|
LGTM |
|
I think such of the non-atomic problems should be solved if we can make use of atomic operations? I know that all storage backend zookeeper/consol/etcd/boltdb support atomic put/delete of multiple KVs. Perhaps libkv should support atomic put/delete of multiple KVs. |
WeiZhang555
pushed a commit
to WeiZhang555/moby
that referenced
this pull request
Nov 25, 2016
… shutdown cherry-pick from upstream see moby/libnetwork#1119 and moby/libnetwork#1130 Signed-off-by: Alessandro Boch <aboch@docker.com> Signed-off-by: Jana Radhakrishnan <mrjana@docker.com> Signed-off-by: Lei Jitang <leijitang@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: moby/moby#23078
Signed-off-by: Alessandro Boch aboch@docker.com