Fix sandbox cleanup #1805
Open
Fix sandbox cleanup #1805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcrisciani
force-pushed
the
port_allocated
branch
from
2da72d7
to
386f313
Compare
Driver and Sanbox have 2 different stores where the endpoints are saved It is possible that the 2 store go out of sync if the endpoint is added to the driver but there is a crash before the sandbox join. On restart now we take the list of endpoints from the network and we assign them back to the sandbox Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
fcrisciani
force-pushed
the
port_allocated
branch
from
386f313
to
1bf6210
Compare
vieux
reviewed
Aug 11, 2017
| for _, ep := range epl { | ||
| ep, err = n.getEndpointFromStore(ep.id) | ||
| if err != nil { | ||
| logrus.Warnf("Could not get endpoint in network %s during sandbox cleanup: %v", n.name, err) |
There was a problem hiding this comment.
maybe logrus.Warnf("Could not get endpoint %s in network %s during sandbox cleanup: %v", ep.id, n.name, err)
|
besides a small nit, LGTM |
lmbarros
pushed a commit
to balena-os/balena-libnetwork
that referenced
this pull request
Apr 17, 2023
Driver and Sanbox have 2 different stores where the endpoints are saved It is possible that the 2 store go out of sync if the endpoint is added to the driver but there is a crash before the sandbox join. On restart now we take the list of endpoints from the network and we assign them back to the sandbox (This is a balena cherry-pick of moby#1805) Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
lmbarros
pushed a commit
to balena-os/balena-libnetwork
that referenced
this pull request
Apr 18, 2023
Driver and Sandbox have 2 different stores where the endpoints are saved It is possible that the 2 store go out of sync if the endpoint is added to the driver but there is a crash before the sandbox join. On restart now we take the list of endpoints from the network and we assign them back to the sandbox (This is a balena cherry-pick of moby#1805) Signed-off-by: Flavio Crisciani <flavio.crisciani@docker.com>
lmbarros
added a commit
to balena-os/balena-engine
that referenced
this pull request
Apr 18, 2023
This new version has a patch cherry-picked from here: moby/libnetwork#1805 This patch is meant to avoid cases in which libnetwork internal state gets inconsistent in case of crashes. Signed-off-by: Leandro Motta Barros <leandro@balena.io> Change-type: patch
lmbarros
added a commit
to balena-os/balena-engine
that referenced
this pull request
Apr 20, 2023
This new version has a patch cherry-picked from here: moby/libnetwork#1805 This patch is meant to avoid cases in which libnetwork internal state gets inconsistent in case of crashes. Signed-off-by: Leandro Motta Barros <leandro@balena.io> Change-type: patch
|
Hi folks! Not sure what are your plans regarding this PR, but let me share some positive experience we had with it at balena:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Driver and Sanbox have 2 different stores where the endpoints are saved
It is possible that the 2 store go out of sync if the endpoint is added to the driver
but there is a crash before the sandbox join.
On restart now we take the list of endpoints from the network and we assign
them back to the sandbox
Signed-off-by: Flavio Crisciani flavio.crisciani@docker.com