Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

racy tests TestRunContainerWithRmFlagExitCodeNotEqualToZero TestRunContainerWithRmFlagCannotStartContainer #11966

Closed
jessfraz opened this issue Mar 31, 2015 · 5 comments · Fixed by #12206
Closed

racy tests TestRunContainerWithRmFlagExitCodeNotEqualToZero TestRunContainerWithRmFlagCannotStartContainer #11966

jessfraz opened this issue Mar 31, 2015 · 5 comments · Fixed by #12206
Assignees
@jessfraz
Labels
area/storage/overlay exp/intermediate kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Comments

@jessfraz
Copy link
Contributor 

--- FAIL: TestRunContainerWithRmFlagExitCodeNotEqualToZero (0.65s)
    docker_cli_run_test.go:3414: Expected not to have containers b236c1619dcc

--- FAIL: TestRunContainerWithRmFlagCannotStartContainer (0.51s)
    docker_cli_run_test.go:3435: Expected not to have containers b236c1619dcc

on overlay specifically
see https://jenkins.dockerproject.com/job/Docker%20Master%20(overlay%20on%20overlay)/132/console
@jessfraz jessfraz added exp/intermediate kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Mar 31, 2015
@jessfraz
Copy link
Contributor Author

bonus points:

--- FAIL: TestPsListContainers (2.06s)
    docker_cli_ps_test.go:59: Container list is not in the correct order
    docker_cli_ps_test.go:128: Container list is not in the correct order
    docker_cli_ps_test.go:138: Container list is not in the correct order
[PASSED]: ps - test ps size
[PASSED]: ps - test ps filter status
[PASSED]: ps - test ps filter id
[PASSED]: ps - test ps filter name
[PASSED]: ps - test ps filter label
--- FAIL: TestPsListContainersFilterExited (2.33s)
    docker_cli_ps_test.go:535: Should be 2 zero exited containerst got 3

@jessfraz
Copy link
Contributor Author

also see #11959

@runcom runcom mentioned this issue Mar 31, 2015
Closed
@jessfraz
Copy link
Contributor Author

jessfraz commented Apr 8, 2015

#dibs this one is mine

@jessfraz jessfraz self-assigned this Apr 8, 2015
@thaJeztah
Copy link
Member

@jfrazelle looks like @runcom was working on this in #11973. Can you check with him and close that PR?

@jessfraz
Copy link
Contributor Author

jessfraz commented Apr 8, 2015

ya no worries im taking on the others and ill see if his works for the one he fixed :)

@jessfraz jessfraz mentioned this issue Apr 8, 2015
Merged
@thaJeztah thaJeztah mentioned this issue Dec 23, 2021
Merged
@crazy-max crazy-max mentioned this issue May 25, 2022
Closed
@thaJeztah thaJeztah mentioned this issue May 25, 2022
Merged
@thaJeztah thaJeztah mentioned this issue Jun 2, 2022
Open
@thaJeztah thaJeztah mentioned this issue Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessfraz jessfraz

Labels
area/storage/overlay exp/intermediate kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup/fix integration-cli for overlay in overlay jessfraz/docker
Fix racy test runcom/docker
3 participants
@jessfraz @thaJeztah @GordonTheTurtle