Proposal:docker should have a grace way to quit the docker stats container_id

[cc272309126]

I think there should be a grace way to quit the docker stats container_id like below

1. docker run -d image_id
2. docker stats container_id
3. press the key 'q' or other key it will exit the docker stats routine. Now it use ctrl+c to exit it.

[phemmer]

What is wrong with ctrl+cl? ctrl+c is a standard way of quitting console based applications.

[thaJeztah]

I think ctrl-c is fine, but it could be convenient if q was added; docker stats "feels" a bit like top and out of habit users may try q to exit stats.

@crosbymichael thoughts?

[phemmer]

The only thing I think that might complicate this is that for q to work, the tty has to be in character-input mode. This is easy enough to do on unix, but it's not cross platform. And with windows being supported, I dunno how hard this is to do over there.

[thaJeztah]

I dunno how hard this is to do over there.

Well, anything on Windows is hard 😄

At this point I'm just checking if there's any "support" for adding this from the maintainers side. I don't regard this a priority issue in any case, but if there's no backing from the maintainers, there's no reason to keep it open.

We'll see :)

[thaJeztah]

Some additional information / suggestions can be found in #12464

[ahmetb]

@phemmer it might not be as hard as you expected. :) We developed some cool ANSI emulation (docker run -it ubuntu bash works inside cmd.exe) and we'll be improving that. I can't see why this can't be done. :)

[dwo]

For what it's worth, I expected q to be the way to quit when I saw docker stats for the first time.

Even if ctrl-c remains only way to do this, I think it'd be nice to make it obvious (eg. Press ctrl-c to exit somewhere while it is running).

[smunsonNamely]

CTL-C also kills the DOS window. This is not cool.

[thaJeztah]

@smunsonNamely could you provide more details on that? CTRL-C should not kill the shell itself (and we tried, but are not able to reproduce that situation)

[Mugane]

Ctrl+c does nothing. Q does nothing... Ctrl+z does nothing! Esc does nothing!! How do I close this thing?! MinGQ64/Docker Quickstart on Windows.

[JannemanDev]

We use this stats command from a shell script and want to return to our menu. Now crtl-c quits our whole script and users cant return to our menu. A simple q would be nice.

[dlt-green]

We use this stats command from a shell script and want to return to our menu. Now crtl-c quits our whole script and users cant return to our menu. A simple q would be nice.

we have the same problem, we wanted to close the live stream maybe with any key or Q, crtl-c is there a very uncool solution, because this breaks also shell skripts