docker start exits with code 0 on error

[mkscrg]

Scripting against docker is complicated by this:

$ sudo docker start invalidid
Error: No such container: invalidid
$ echo $?
0

[crosbymichael]

What do you suggest as an alternative?

[mkscrg]

How about returning 1 when the command fails?

Bash (and friends) treat the exit code 0 as success and non-0 as failure. So with the current situation, this doesn't work as expected:

docker start invalidid && docker attach invalidid

The first command fails, but the second command runs anyway because the first command returned 0.

[crosbymichael]

@mkscrg what about the error message?

[mkscrg]

The message is great! It's just the exit code that's troublesome.

[crosbymichael]

Thanks, this will be resolved with the host integration features. I am tagging this for 0.7.

[mkscrg]

It seems that docker build also returns 0 when a build fails.

[crosbymichael]

Yes you are correct. Docker build is a little more complex because of the stream that we return. It involves a little more refactoring to return the error code.

[flavio]

I think this issue can be closed, docker start now returns 1 when it fails.

The build command is still buggy, but there's issue #1150 which covers it.