Option in daemon.json file for userland-proxy being ignored

[mbentley]

Description of problem:
When using the option in daemon.json file for userland-proxy, it is being ignored.

docker version:

$ docker version
Client:
 Version:      1.10.1
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   9e83765
 Built:        Thu Feb 11 19:15:20 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.1
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   9e83765
 Built:        Thu Feb 11 19:15:20 2016
 OS/Arch:      linux/amd64

docker info:

$ docker info
Containers: 2
 Running: 0
 Paused: 0
 Stopped: 2
Images: 403
Server Version: 1.10.1
Storage Driver: aufs
 Root Dir: /var/lib/docker/aufs
 Backing Filesystem: extfs
 Dirs: 413
 Dirperm1 Supported: true
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local
 Network: bridge null host
Kernel Version: 3.16.0-4-amd64
Operating System: Debian GNU/Linux stretch/sid
OSType: linux
Architecture: x86_64
CPUs: 1
Total Memory: 1.963 GiB
Name: localdev
ID: ABO2:4REM:BS7R:OXYG:R7V6:UJGL:2YTX:CJ7H:UEYY:IK7O:JXYQ:YBYX
Username: mbentley
Registry: https://index.docker.io/v1/
WARNING: No cpu cfs quota support
WARNING: No cpu cfs period support

uname -a:

$ uname -a
Linux localdev 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt20-1+deb8u2 (2016-01-02) x86_64 GNU/Linux

Environment details (AWS, VirtualBox, physical, etc.):
Debian Sid on VirtualBox; running kernel from jessie

How reproducible:
Happens when specifying userland-proxy in my daemon.json file

Steps to Reproduce:

1. Reconfigure the daemon to use a daemon.json file with "userland-proxy": false set in the file (see my file at the end of this issue)
2. Restart the docker daemon
3. Run a container with a port exposed and see the docker-proxy process running

Actual Results:

● docker.service - Docker Application Container Engine
   Loaded: loaded (/lib/systemd/system/docker.service; enabled; vendor preset: enabled)
  Drop-In: /etc/systemd/system/docker.service.d
           └─10-execstart.conf
   Active: active (running) since Fri 2016-02-12 17:16:11 EST; 6min ago
     Docs: https://docs.docker.com
 Main PID: 8310 (docker)
   Memory: 22.9M
      CPU: 485ms
   CGroup: /system.slice/docker.service
           ├─8310 /usr/bin/docker daemon
           ├─8508 docker-proxy -proto tcp -host-ip 0.0.0.0 -host-port 80 -container-ip 172.17.0.2 -container-port 80
           ├─8515 nginx: master process nginx -c /etc/nginx/nginx.con
           ├─8522 nginx: worker process
           └─8523 nginx: worker process

Expected Results:
No docker-proxy process running indicating that the username proxy is not being used

Additional info:

daemon.json:

{
        "debug": false,
        "hosts": ["fd://"],
        "log-config": {
                "log-driver": "json-file",
                "log-opts": ["max-size=10m", "max-file=2"]
        },
        "storage-driver": "aufs",
        "graph": "/var/lib/docker",
        "userland-proxy": false
}

[thaJeztah]

ping @calavera - assigned this to you 😇

[calavera]

I found the issue and I'm working on it, but I think it's not going to be pretty. I have a test to reproduce it, so that's good 😸