Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker swarm inspect and docker info inconsistencies #24148

Closed
aluzzardi opened this issue Jun 29, 2016 · 6 comments
Closed

docker swarm inspect and docker info inconsistencies #24148

aluzzardi opened this issue Jun 29, 2016 · 6 comments
Assignees
Labels
area/api area/cli area/swarm priority/P1 Important: P1 issues are a top priority and a must-have for the next release. status/claimed
Milestone

Comments

@aluzzardi
Copy link
Member

Both docker info and docker swarm inspect display information regarding the swarm.

They do so in a different way.

There are also other inconsistencies in swarm inspect (#23689, #24122).

/cc @stevvooe @aanand @dnephin @tonistiigi

@aluzzardi aluzzardi added area/api area/cli priority/P1 Important: P1 issues are a top priority and a must-have for the next release. area/swarm labels Jun 29, 2016
@aluzzardi aluzzardi added this to the 1.12.0 milestone Jun 29, 2016
@tiborvass
Copy link
Contributor

I suggest we replace swarm inspect with swarm info because it does not expect an argument.
It should be pretty by default, and maybe add --json flag, although I would prefer not having it for 1.12 and adding it to both swarm info and info in a later release.

This means that --pretty could remain on node inspect and service inspect, even though i would expect --pretty be added in a later release to volume inspect and network inspect and inspect.

@tiborvass
Copy link
Contributor

We could also add this information to docker info and remove swarm inspect altogether to stay future proof (in the case there will be multiple swarms to inspect).

@minzhang28
Copy link

Voting for removing swarm inspect as :

  • It's not following the conventions as docker inspect, docker-machine inspect
  • It's only showing the current swam info

@tiborvass
Copy link
Contributor

We decided to remove swarm inspect altogether and just add swarm-specific information to docker info. We need to find a way of merging the existing swarm information in docker info, with the one in swarm inspect currently.

Any takers?

@vdemeester
Copy link
Member

@tiborvass I can take a look at it tomorrow morning 👼 🇫🇷

@aluzzardi
Copy link
Member Author

SGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api area/cli area/swarm priority/P1 Important: P1 issues are a top priority and a must-have for the next release. status/claimed
Projects
None yet
Development

No branches or pull requests

5 participants