Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile reference advises against using build-time variables for secrets but offers no alternative #30627

Closed
underyx opened this issue Feb 1, 2017 · 3 comments

Comments

@underyx
Copy link

underyx commented Feb 1, 2017

The ARG section says the following:

Warning: It is not recommended to use build-time variables for passing secrets like github keys, user credentials etc. Build-time variable values are visible to any user of the image with the docker history command.

This, however, is not very helpful. The warning should mention what to use instead when you need secrets during build time.

@justincormack
Copy link
Contributor

The plan is to add #28079 at some point I believe, so that the currently swarm runtime only secrets are also available at build time. cc @ehazlett

In terms of what to do right now, yes some more docs would be good.

@ehazlett
Copy link
Contributor

ehazlett commented Feb 6, 2017

@underyx as justin said, we hope to improve the build options. I have rebased and opened a PR for build (GH wouldn't let me re-open the original) and would love your feedback -- #30637

@thaJeztah
Copy link
Member

I think the question is answered, and the discussion currently takes place on #30637, so let me close this issue to prevent the discussion from diverging, but thanks for reporting (and, yes, I agree build-time secrets are badly needed 😇 #13490)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants