Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONMessage structure definitions shouldn't pull in TTY libs #33461

Open
dhiltgen opened this issue May 31, 2017 · 4 comments
Open

JSONMessage structure definitions shouldn't pull in TTY libs #33461

dhiltgen opened this issue May 31, 2017 · 4 comments
Labels
kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Comments

@dhiltgen
Copy link
Contributor

Downstream projects that want to leverage the payloads from pull, load, etc. need some way to parse the messages coming back. This currently lives in https://github.com/moby/moby/blob/master/pkg/jsonmessage/jsonmessage.go

Unfortunately, the type definitions are intertwined with TTY code for CLI handling.

These should be split out, ideally into the client library so downstream projects can easily consume the standard structure definitions.

@sheerun
Copy link

sheerun commented Apr 21, 2018

Please :) This is also needed for parsing output of client.ImagePull

@sheerun
Copy link

sheerun commented Apr 21, 2018

Reference: docker/engine-api#89

@thaJeztah
Copy link
Member

/cc @stevvooe @cpuguy83

@wminshew
Copy link

wminshew commented Aug 7, 2018

+1; unable to pull cleanly with dep. Going to hack around for now, but not ideal.

@bsousaa bsousaa added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
None yet
Development

No branches or pull requests

5 participants