Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add -add flag to docker run #3578

Closed
proppy opened this issue Jan 13, 2014 · 10 comments
Closed

add -add flag to docker run #3578

proppy opened this issue Jan 13, 2014 · 10 comments
Labels
kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny

Comments

@proppy
Copy link
Contributor

proppy commented Jan 13, 2014

It would be nice to have a new flag to allow adding a file (not mounting) inside the container before running it.

This could deprecate the insert command that is weirdly limited to URL and bring the CLI experience in line what what you can do in a Dockerfile

@crosbymichael
Copy link
Contributor

I"m not sure about this @proppy. Why not just bind mount ro or do an ADD?

@proppy
Copy link
Contributor Author

proppy commented Mar 16, 2014

@crosbymichael if you don't have a Dockerfile you can't ADD, and if you mount it doesn't persist if you commit the container to an image.

@SvenDowideit
Copy link
Contributor

And bind-mount doesn't work unless you happen to be working on the same host as the docker daemon.

@proppy
Copy link
Contributor Author

proppy commented Apr 19, 2014

Related to #3050, if ADD get split similar functionality should be added to docker CLI.

/cc @pda

@proppy proppy changed the title add -cp flag to docker run add -add flag to docker run Apr 19, 2014
@duglin
Copy link
Contributor

duglin commented Sep 29, 2014

Would it work if you did this?
docker create ...
docker cp ...
docker start ....
assuming you could do "docker cp" from the host to a stopped container.

@jessfraz
Copy link
Contributor

@proppy hiiii! is this still relevant? do you think we still need it :)

@proppy
Copy link
Contributor Author

proppy commented Jan 16, 2015

@jfrazelle yes, there is still no clean way to add a set of files to a container and commit from the CLI/API, w/o doing ADD in a Dockerfile or messing with stdin.

It means that you can't really do everything that a Dockerfile is doing, with docker base commands.

@jessfraz jessfraz added the kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny label Feb 27, 2015
@duglin
Copy link
Contributor

duglin commented Jul 14, 2015

@proppy is it ok if we close this with the assumption that #13171 will solve your issue?

@proppy
Copy link
Contributor Author

proppy commented Jul 15, 2015

Sure.

@proppy proppy closed this as completed Jul 15, 2015
@duglin
Copy link
Contributor

duglin commented Jul 15, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Functionality or other elements that the project doesn't currently have. Features are new and shiny
Projects
None yet
Development

No branches or pull requests

5 participants