Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration package is not ran on the windowsRS1 CI #36748

Closed
vdemeester opened this issue Mar 30, 2018 · 4 comments · Fixed by #39240
Closed

integration package is not ran on the windowsRS1 CI #36748

vdemeester opened this issue Mar 30, 2018 · 4 comments · Fixed by #39240
Labels
area/project area/testing priority/P1 Important: P1 issues are a top priority and a must-have for the next release.

Comments

@vdemeester
Copy link
Member

A while back (after the cli split actually), the integration folder was created to create new integration test suites (based on testing, simpler, smaller and using only the API.

The different CI scripts were updated to take those into account except the windows one. We have to update the windows CI scripts to also run those.

cc @jhowardmsft @johnstep

(on a side note, it would make it way easier if those were directly on this repository)

@vdemeester vdemeester added area/testing priority/P1 Important: P1 issues are a top priority and a must-have for the next release. area/project labels Mar 30, 2018
@lowenna
Copy link
Member

lowenna commented Mar 30, 2018

I started on this a little while ago - some of the tests don't actually work/weren't ported to Windows correctly. https://github.com/Microsoft/docker/tree/jjh/enable-integration. I'm not sure this is necessarily P1 though ;)

@vdemeester
Copy link
Member Author

@jhowardmsft made it P1 to make sure we work on that next week — I can help with fixing the tests that don't run on the windowsRS1 😉, it's just that the powershell in the CI (jenkins) is a bit obscure to me 👼. If you have an update to that script that would enable that, I can duplicate the CI job to fix tests before using it on the PR job 👼

@lowenna
Copy link
Member

lowenna commented Mar 30, 2018

I have a partial bit of it working in branch jjh/integration in the CI scripts repo. I can't recall exactly how far I got, but the first step was to rename integration to integrationcli. This all needs to be plumbed through in Invoke-DockerCI too. I unfortunately have no time to work on this for the next few weeks as I have some RS5 deliverables to focus on.

@vdemeester
Copy link
Member Author

@jhowardmsft ok, fair enough, I'll dig into the repo next week and try to enhance my Powershell knowledge to help on that 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/project area/testing priority/P1 Important: P1 issues are a top priority and a must-have for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants