check-config.sh script doesn't work with Kernel 5.2 (IP_NF_NAT)

[Dmole]

https://github.com/moby/moby/blob/master/contrib/check-config.sh#L194

in Kernel 5.2 it's IP_NF_NAT (not NF_NAT_IPV4)

[Dmole]

also
NF_NAT_NEEDED -> NF_NAT
IOSCHED_CFQ -> IOSCHED_BFQ
CFQ_GROUP_IOSCHED -> BFQ_GROUP_IOSCHED

[thaJeztah]

@Dmole are you interested in contributing, and opening a pull request to add support for the new names to the script? (note that both the old and new names should work, as older kernels are of course still supported).

[Dmole]

First guessing the cut offs;
NF_NAT_IPV4 -> IP_NF_NAT (>5.0)

• https://cateee.net/lkddb/web-lkddb/NF_NAT_IPV4.html
• https://cateee.net/lkddb/web-lkddb/IP_NF_NAT.html

NF_NAT_NEEDED -> NF_NAT (>5.1)

• https://cateee.net/lkddb/web-lkddb/NF_NAT_NEEDED.html
• https://cateee.net/lkddb/web-lkddb/NF_NAT.html

IOSCHED_CFQ -> IOSCHED_BFQ (>4.20)

• https://cateee.net/lkddb/web-lkddb/IOSCHED_CFQ.html
• https://cateee.net/lkddb/web-lkddb/IOSCHED_BFQ.html

CFQ_GROUP_IOSCHED -> BFQ_GROUP_IOSCHED (>4.20)

• https://cateee.net/lkddb/web-lkddb/CFQ_GROUP_IOSCHED.html
• https://cateee.net/lkddb/web-lkddb/BFQ_GROUP_IOSCHED.html

[thaJeztah]

Perhaps it could check IP_NF_NAT -> fallback to NF_NAT_IPV4, and mark it as "pass" if one of those is found?

[thaJeztah]

(we should prevent doing that based on kernel version to take into account distros that backport features to older versions)

[Dmole]

Ideally feature instead of version checks are done, but that is not how the script is currently implemented, and possibly for good reasons like it would be hard to know if a feature is experimental/buggy during periods of overlap. (Ideally distributions use a LTS Kernel but that is rare).

Maybe someone can setup a unit test for this to check the kernels on the server versions of RHL/Ubuntu/Manjaro which should cover the common and newest scenarios.

[Dmole]

Yes, I think pass on one of a set enabled is the best, something like

function check{
#...
}

check NF_NAT_IPV4,IP_NF_NAT \
    NF_NAT_NEEDED,NF_NAT \
    IOSCHED_CFQ,IOSCHED_BFQ

[Dmole]

But first #39317

[Dmole]

@thaJeztah bump.