Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkpoint fails with shimv2 #41531

Closed
cpuguy83 opened this issue Oct 6, 2020 · 4 comments · Fixed by #41546
Closed

Checkpoint fails with shimv2 #41531

cpuguy83 opened this issue Oct 6, 2020 · 4 comments · Fixed by #41546
Labels
area/checkpoint Related to (experimental) checkpoint/restore (CRIU) kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. kind/experimental
Projects
20.10 planning

Comments

@cpuguy83
Copy link
Member

cpuguy83 commented Oct 6, 2020

Calling docker checkpoint with the (now default) v2 shim yields an error from the shim:

invalid task checkpoint option for io.containerd.runc.v2: unknown
@cpuguy83 cpuguy83 added the kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. label Oct 6, 2020
@cpuguy83 cpuguy83 added this to To do in 20.10 planning via automation Oct 6, 2020
@cpuguy83
Copy link
Member Author

cpuguy83 commented Oct 6, 2020

/cc @AkihiroSuda

@yufeifly
Copy link
Contributor

I encounterd this bug too.

@rst0git
Copy link
Contributor

rst0git commented Oct 11, 2020 •
edited
Loading

The way containers are restored with containerd was changed in containerd/containerd#2632 (e.g., containerd/containerd#2973)

containerd v1.2:

containerd.WithCheckpoint(checkpoint, "redis-rootfs")

containerd v1.3:

containerd.WithNewSnapshot("redis-rootfs", checkpoint)

As a result, checkpoint/restore in moby/docker was broken with commit d4c6372.

@rst0git rst0git mentioned this issue Oct 11, 2020
Closed
@cpuguy83
Copy link
Member Author

The issue is with type checking for different runtimes.
We're using the checkpoint type for the v1 runtime only.

I'll prepare a patch for this.

@cpuguy83 cpuguy83 mentioned this issue Oct 12, 2020
Merged
@cpuguy83 cpuguy83 moved this from To do to Review in progress in 20.10 planning Oct 12, 2020
@cpuguy83 cpuguy83 moved this from Review in progress to To do in 20.10 planning Oct 12, 2020
20.10 planning automation moved this from To do to Done Oct 15, 2020
@thaJeztah thaJeztah added kind/experimental area/checkpoint Related to (experimental) checkpoint/restore (CRIU) labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/checkpoint Related to (experimental) checkpoint/restore (CRIU) kind/bug Bugs are bugs. The cause may or may not be known at triage time so debugging may be needed. kind/experimental
Projects
No open projects
20.10 planning
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"Fix" checkpoint on v2 runtime cpuguy83/docker
4 participants
@cpuguy83 @thaJeztah @rst0git @yufeifly