Unreachable else if case in docker_cli_build_test.go

[vastjs]

docker_cli_build_test.go contains an unreachable else if case on line 216-220.

		if parts[0] == "bar" {
			found = true
			if parts[1] != "zzz" {
				c.Fatalf("Could not find replaced var for env `bar`: got %q instead of `zzz`", parts[1])
			}
		} else if strings.HasPrefix(parts[0], "env") {
			envCount++
			if parts[1] != "zzz" {
				c.Fatalf("%s should be 'zzz' but instead its %q", parts[0], parts[1])
			}
		} else if strings.HasPrefix(parts[0], "env") {
                        // unreachable
			envCount++
			if parts[1] != "foo" {
				c.Fatalf("%s should be 'foo' but instead its %q", parts[0], parts[1])
			}
		}

It is unclear to me if the else if block is just a duplicate and can be just removed. Because its body differs from the block above.

[thaJeztah]

Nice catch; I see that was added in 39908fc (#11149), and (just at a quick glance), looks like it's just a duplicate (perhaps the original intent was to add more test-cases to TestBuildEnvironmentReplacementEnv() ?)