Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd integration: implement "prune" (--no-prune) option for image delete #43849

Closed
thaJeztah opened this issue Jul 21, 2022 · 1 comment · Fixed by #45427
Closed

containerd integration: implement "prune" (--no-prune) option for image delete #43849

thaJeztah opened this issue Jul 21, 2022 · 1 comment · Fixed by #45427
Labels
area/images containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Comments

@thaJeztah
Copy link
Member

Description

The containerd implementation does not yet implement the prune option

Existing implementation can be found in

func (i *ImageService) imageDeleteHelper(imgID image.ID, records *[]types.ImageDeleteResponseItem, force, prune, quiet bool) error {

We should look if this option still makes sense, or if we should deprecate it; it looks now to (mostly) the classic builder, which has a concept of "parent" images (before docker 1.10, all images had "parent" images, but that's no longer the case).

@thaJeztah thaJeztah added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. area/images containerd-integration Issues and PRs related to containerd integration labels Jul 21, 2022
@laurazard
Copy link
Member

Closing/moving to done since this was fixed by #45427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/images containerd-integration Issues and PRs related to containerd integration kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants