Adding support for RISC-V

[advancedwebdeveloper]

Description

CC @lazyparser

I caught an error, on RISC-V:

$ make all
docker build --build-arg=GO_VERSION -f "Dockerfile" --target=final -t "docker-dev" .
[+] Building 127.9s (10/10) FINISHED
=> [internal] load build definition from Dockerfile 2.4s
=> => transferring dockerfile: 19.30kB 1.4s
=> [internal] load .dockerignore 0.7s
=> => transferring context: 145B 0.4s
=> resolve image config for docker.io/docker/dockerfile:1 11.2s
=> docker-image://docker.io/docker/dockerfile:1@sha256:9ba7531bd80fb0a8 67.8s
=> => resolve docker.io/docker/dockerfile:1@sha256:9ba7531bd80fb0a858632 0.3s
=> => sha256:9ba7531bd80fb0a858632727cf7a112fbfd19b17e94 2.00kB / 2.00kB 0.0s
=> => sha256:5e015bf33c30723c95127c9479cbb1794a59b0e94b7c398 528B / 528B 0.0s
=> => sha256:ff43dfbc6c873cc43ff094ebb07a8844008696f1886 2.37kB / 2.37kB 0.0s
=> => sha256:3d5d8443811725e865cd78c06e40f01466d0cbe9fb 9.58MB / 9.58MB 26.4s
=> => extracting sha256:3d5d8443811725e865cd78c06e40f01466d0cbe9fb5f27e 33.6s
=> [internal] load build definition from Dockerfile 0.0s
=> [internal] load .dockerignore 0.1s
=> ERROR [internal] load metadata for docker.io/library/golang:1.19.2-bu 7.4s
=> ERROR [internal] load metadata for docker.io/library/debian:bullseye 8.4s
=> CANCELED [internal] load metadata for docker.io/djs55/vpnkit:0.5.0 9.6s
=> CANCELED [internal] load metadata for docker.io/djs55/vpnkit:0.5.0 9.1s

[internal] load metadata for docker.io/library/golang:1.19.2-bullseye:

---

---

[internal] load metadata for docker.io/library/debian:bullseye:

---

failed to solve with frontend dockerfile.v0: failed to solve with frontend gateway.v0: rpc error: code = Unknown desc = no match for platform in manifest sha256:80ede0f12980ec4fc580fa651aabff041d46d1255b323fa0b740ecbce9f89256: not found
make: *** [Makefile:220: build] Error 1

I wonder if any people interested on a 64bit RISC-V support

[crazy-max]

See PR description about riscv64 support: #43529 (comment)

To add support for riscv64 builds we need crossbuild packages for riscv64 but current golang image with debian bullseye does not support it. Ubuntu 22.04 supports riscv64 but unfortunately drops support for armel arch. Therefore we need a multi base image that will be picked up based on the target platform we want to build.

See also #43553 (comment)

[AkihiroSuda]

This also needs runc v1.2 to be released

• release: build riscv64 binary, build static PIE if supported opencontainers/runc#3446

[luhenry]

Hello,

In the context of adoptium/adoptium-support#697, we've run into an issue with running Java on RISC-V inside Docker. The issue boils down to the riscv_flush_icache syscall failing with EPERM leading to executing stale instructions. It is fixed with #43553 on Moby 23 and later.

That issue arises on Ubuntu 22.04 which ships docker.io v20.10. Unfortunately, it is the only build available on RISC-V at the moment. The docker.io package coming from the Ubuntu repositories (on Ubuntu 22.04 and later) is still at 20.10, and the Docker repositories don't support riscv64.

There are then multiple solution I can see:

1. work with Debian and Ubuntu to backport seccomp: support riscv64 #43553 to 20.10 to all relevant Debian and Ubuntu versions
2. backport seccomp: support riscv64 #43553 to 20.10
3. provide builds in the Docker repositories for riscv64

At the moment, without this patch, it's simply not possible to run Java in Docker on any current versions of Ubuntu or Debian on RISC-V out of the box. (Workarounds are to run with seccomp=unconfined or write a custom seccomp profile that copy/paste what's in that patch.)

I'm not fully familiar with the relationship between Moby and Docker so it's not clear to me what would be the best step(s) forward, and I would greatly appreciate your feedback on that!

Thanks for your input.

[AkihiroSuda]

3. provide builds in the Docker repositories for riscv64

👍
dpkgs are built here: https://github.com/docker/docker-ce-packaging/blob/b09da57452865f3f7f6ab510a79821f653a5c0a5/common.mk#L13

You also need to wait for:

• Backport riscv64 support into 1.1.x opencontainers/runc#3905

[crazy-max]

Also related to #44735

[luhenry]

dpkgs are built here: https://github.com/docker/docker-ce-packaging/blob/b09da57452865f3f7f6ab510a79821f653a5c0a5/common.mk#L13

@AkihiroSuda are you suggesting I submit a PR to add riscv64? I'd be happy to do that but I assume it's not that simple?

[ilg-ul]

Ubuntu 23.04 already provides functional docker packages for RISC-V, but attempts to use the docker specific install procedure fail with:

N: Skipping acquire of configured file 'stable/binary-riscv64/Packages' as repository 'https://download.docker.com/linux/ubuntu lunar InRelease' doesn't support architecture 'riscv64'

since RISC-V is not listed as a supported architecture (for example in https://download.docker.com/linux/ubuntu/dists/lunar/stable/).

Is there anything I can do to help add support for the RISC-V Ubuntu distribution?