Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker save: does not preserve the "json" #6455

Closed
vbatts opened this issue Jun 16, 2014 · 1 comment · Fixed by #6571
Closed

docker save: does not preserve the "json" #6455

vbatts opened this issue Jun 16, 2014 · 1 comment · Fixed by #6571
Milestone
1.1.0

Comments

@vbatts
Copy link
Contributor

vbatts commented Jun 16, 2014

Since presently the docker save uses the "image_inspect" job [0] to get the json, this marshal's the json file, which could reorder, or even changing the key formatting. Both of these will alter the tarsum of the image.

[0] https://github.com/dotcloud/docker/blob/master/server/server.go#L435
@vbatts
Copy link
Contributor Author

vbatts commented Jun 16, 2014

this is related to #6385 (comment)

@vieux vieux added this to the 1.0.1 milestone Jun 16, 2014
@vieux vieux mentioned this issue Jun 17, 2014
Closed
@vieux vieux modified the milestones: 1.0.2, 1.0.1 Jun 20, 2014
@vbatts vbatts mentioned this issue Jun 20, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

raw json for docker save vbatts/moby
Do not alter json in docker save vieux/docker
2 participants
@vbatts @vieux