Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd executor should be smarter about containerd events subscription #2219

Closed
ijc opened this issue Jun 6, 2017 · 3 comments · Fixed by #2568
Closed

containerd executor should be smarter about containerd events subscription #2219

ijc opened this issue Jun 6, 2017 · 3 comments · Fixed by #2568
Assignees
@ijc

Comments

@ijc
Copy link
Contributor

ijc commented Jun 6, 2017

The containerd executor added in #1965 currently starts a containerd event stream for every task. These event streams contain events for all containers which containerd is managing. We should either:

  • Make use of server side filtering in containerd (not yet implemented) to request a per-task stream which only contains events relevant to the task.
  • Setup a singleton event stream on the client side which demuxes into multiple per task event streams.

My preference is to do the former.
@ijc ijc mentioned this issue Jun 6, 2017
Merged
@ijc
Copy link
Contributor Author

ijc commented Jun 22, 2017

With #2275 this issue is pushed down into the container.Task.Wait() method. The code puts @ehazlett on the hook for that, but I'm not sure if there is an issue over there yet.

@ijc
Copy link
Contributor Author

ijc commented Jun 22, 2017

Thanks! I'll leave this here at least until #2275 is merged I think.

@ijc
Copy link
Contributor Author

ijc commented Jun 22, 2017

Correct containerd link: containerd/containerd#1066

ijc added a commit to ijc/swarmkit that referenced this issue Mar 23, 2018
@ijc
Remove the containerd executor
1cc057c 
It targets an old pre v1.0 alpha version of containerd and is not currently
maintained.

closes moby#2219, closes moby#2258, closes moby#2259 and closes moby#2299.

The vendoring of libtrust did not become obsolete here but vndr noted that it
was unused so I dropped it while I was there.

Signed-off-by: Ian Campbell <ijc@docker.com>
@ijc ijc mentioned this issue Mar 23, 2018
Merged
ijc added a commit to ijc/swarmkit that referenced this issue Mar 23, 2018
@ijc
Remove the containerd executor
fe9b063 
It targets an old pre v1.0 alpha version of containerd and is not currently
maintained.

closes moby#2219, closes moby#2258, closes moby#2259 and closes moby#2299.

The vendoring of libtrust did not become obsolete here but vndr noted that it
was unused so I dropped it while I was there.

Signed-off-by: Ian Campbell <ijc@docker.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ijc ijc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the containerd executor ijc/swarmkit
1 participant
@ijc