Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StopOptions for ContainerRestart and ContainerStop from moby/moby #3081

Closed
eclipseo opened this issue Oct 9, 2022 · 1 comment · Fixed by #3103
Closed

Implement StopOptions for ContainerRestart and ContainerStop from moby/moby #3081

eclipseo opened this issue Oct 9, 2022 · 1 comment · Fixed by #3103

Comments

@eclipseo
Copy link
Contributor

eclipseo commented Oct 9, 2022

In:

moby/moby@90de570#diff-03c9c5106ca2725bfd9ca8d4d9e46a9f988aa9c28d086f4477c87d05ea72967c

moby/moby implemented StopOptions to ContainerRestart and ContainerStop.

This has not been reflected in Swarmkit amd now I'm having trouble to build swarmkit against the Moby beta. Would it be possible to implement it please?

Thank you.
@s4ke
Copy link
Contributor

s4ke commented Nov 8, 2022 •
edited

I looked into this, and while most of this is just a replacement of types to get it to compile, one of the tests fails, namely TestAllocateWithInvalidSubnet which leads to a call to moby/moby ipam.RequestPool(asName, ic.Subnet, ic.Range, dOptions, false) :

grafik

s4ke added a commit to s4ke/swarmkit that referenced this issue Nov 8, 2022
@s4ke
Upgrade moby/moby dependencies to reflect StopOptions change
dc4402b 
fix moby#3081

Signed-off-by: Martin Braun <braun@neuroforge.de>
@s4ke s4ke mentioned this issue Nov 8, 2022
Closed
s4ke added a commit to s4ke/swarmkit that referenced this issue Nov 8, 2022
@s4ke
Upgrade moby/moby dependencies to reflect StopOptions change
0277a25 
fix moby#3081

Signed-off-by: Martin Braun <braun@neuroforge.de>
@corhere corhere mentioned this issue Nov 9, 2022
Closed
@thaJeztah thaJeztah mentioned this issue Nov 10, 2022
Closed
@thaJeztah thaJeztah mentioned this issue Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@s4ke @eclipseo