api: add support for containers that require TTY #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2016
Current coverage is 55.15% (diff: 100%)@@ master #1370 diff @@
==========================================
Files 80 80
Lines 12641 12638 -3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6977 6970 -7
- Misses 4698 4701 +3
- Partials 966 967 +1
|
|
LGTM |
|
17 days old, no updates, needs rebase. Still want to push this through @stevvooe ? |
|
@dperny See moby/moby#25644 (comment) from @crosbymichael on the support of TTYs. |
|
I repoened this. I couldn't find a better alternative to having generic support for a system level console in normal containers are this point. Sorry for slowing this PR down. |
Signed-off-by: Stephen J Day <stephen.day@docker.com>
stevvooe
force-pushed
the
add-tty-support
branch
from
c9fc8ba
to
9293079
Compare
|
LGTM |
|
LGTM @stevvooe: Once this is merged, will you be opening a docker/docker PR to add support for it in the CLI and executor? |
I don't have any plans to. If it is not implemented by code freeze, I can take this on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stephen J Day stephen.day@docker.com