Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Use TaskStatus Err field for non-terminal errors #2287

Merged
merged 1 commit into from
Oct 9, 2017
Merged

api: Use TaskStatus Err field for non-terminal errors #2287

merged 1 commit into from
Oct 9, 2017

Commits on Jun 27, 2017

  1. api: Use TaskStatus Err field for non-terminal errors 

    There are some cases when a task can't advance from a particular state
because preconditions are not met. For example, if no nodes meet its
constraints, it will not advance to "assigned".

Currently, we put a note about this in the Message field of TaskStatus,
but this is not surfaced to the user. It wouldn't make sense to expose
Message prominently because it usually contains uninteresting notes
about how the task reached that state. Its presence does not indicate
that something is wrong.

Expand the scope of Err to also cover non-terminal errors that are
blocking the task from progressing, and use it in those cases.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
    @aaronlehmann
    aaronlehmann committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    fc6ef74 View commit details
    Browse the repository at this point in the history