Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watchapi: Terminate RPCs when the manager shuts down #2310

Merged
merged 1 commit into from
Jul 19, 2017
Merged

watchapi: Terminate RPCs when the manager shuts down #2310

merged 1 commit into from
Jul 19, 2017

Commits on Jul 14, 2017

  1. watchapi: Terminate RPCs when the manager shuts down 

    Because we use GracefulStop, RPCs need to finish on their own when the
manager shuts down.

The watchapi server formerly was completely stateless, and didn't have a
notion of starting or stopping.

This adds Start and Stop functions that control a context, adapted from
the logbroker code. When the context is cancelled, outstanding RPCs will
finish.

There are also some related cleanups and fixes in the logbroker code.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
    @aaronlehmann
    aaronlehmann committed Jul 14, 2017
    Configuration menu
    Copy the full SHA
    6a9946b View commit details
    Browse the repository at this point in the history