Introduce system service flag to service spec [WIP] #2547
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nishanttotla
reviewed
Mar 9, 2018
api/specs.proto
Outdated
| // happen on a node. | ||
| // Note that this only applies to a global service, since a typical use-case would | ||
| // require these services to run on all nodes. | ||
| bool systemservice = 10; |
There was a problem hiding this comment.
I know this is WIP, but can you make this system_service so that the go field will be SystemService before it becomes harder?
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #2547 +/- ##
==========================================
+ Coverage 61.46% 66.24% +4.77%
==========================================
Files 134 80 -54
Lines 21800 11636 -10164
==========================================
- Hits 13399 7708 -5691
+ Misses 6958 3142 -3816
+ Partials 1443 786 -657 |
…ices. Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces the system services flag to global services, the current application is to allow certain system services to continue running on drained nodes.