Fix deepcopy.Copy panicing with BoolValue
#2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, trying to create a service with `Init` (which is a BoolValue) would panic. It is now fixed. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
This was referenced May 31, 2018
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
+ Coverage 61.85% 61.88% +0.03%
==========================================
Files 134 134
Lines 21823 21823
==========================================
+ Hits 13499 13506 +7
+ Misses 6869 6868 -1
+ Partials 1455 1449 -6 |
anshulpundir
approved these changes
May 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, trying to create a service with
Init(which is aBoolValue) would panic. It is now fixed.
Before,
swarmctl service create --init --name=foo --image nginx:alpinewould make the daemon panic, after, it creates the container with the correct spec.Required for moby/moby#37183 and carrying docker/cli#479
Signed-off-by: Vincent Demeester vincent@sbr.pm