Remove unused "containerd-addr" and "containerd-namespace" flags #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit fe9b063 removed the containerd executor, as it was not currently maintained, but these two flags were left behind and are no longer functional. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #2704 +/- ##
==========================================
+ Coverage 61.79% 61.79% +<.01%
==========================================
Files 134 134
Lines 21764 21764
==========================================
+ Hits 13448 13449 +1
+ Misses 6873 6862 -11
- Partials 1443 1453 +10 |
ijc
approved these changes
Jul 11, 2018
nishanttotla
approved these changes
Jul 11, 2018
|
PURGE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit fe9b063 (#2568) removed the containerd executor, as it was not currently maintained, but these two flags were left behind and are no longer functional.
see #2595 (comment)