Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] Backport of Increase grpc max recv message size #2776

Merged
merged 1 commit into from Oct 31, 2018

Conversation

anshulpundir
Copy link
Contributor

Backports #2775

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "1809" git@github.com:anshulpundir/swarmkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842362794960
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@anshulpundir anshulpundir changed the base branch from master to bump_v18.09 October 31, 2018 21:53
Increases the maximum recieved message size for gRPC client connections
to math.MaxInt32. This means that large controlapi List requests will be
proxied correctly.

Signed-off-by: Drew Erny <drew.erny@docker.com>
(cherry picked from commit 25c6d44)

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
Copy link
Member

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu
Copy link
Member

oh, hmm...circleci failed

@wk8 wk8 merged commit 063ec72 into moby:bump_v18.09 Oct 31, 2018
@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #2776 into bump_v18.09 will decrease coverage by 0.1%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##           bump_v18.09    #2776      +/-   ##
===============================================
- Coverage        61.83%   61.72%   -0.11%     
===============================================
  Files              134      134              
  Lines            21859    21862       +3     
===============================================
- Hits             13517    13495      -22     
- Misses            6880     6901      +21     
- Partials          1462     1466       +4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants