fix: code optimization #3135
Merged
fix: code optimization #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
Codecov Report
@@ Coverage Diff @@
## master #3135 +/- ##
==========================================
+ Coverage 61.69% 61.78% +0.09%
==========================================
Files 154 154
Lines 31120 31117 -3
==========================================
+ Hits 19198 19226 +28
+ Misses 10377 10347 -30
+ Partials 1545 1544 -1 |
thaJeztah
approved these changes
May 31, 2023
Comment on lines
16
to
-17
| "github.com/docker/docker/api/types/container" | ||
| containertypes "github.com/docker/docker/api/types/container" |
There was a problem hiding this comment.
nice catch on these 👍
still wondering what linter we don't have enabled that would catch these (I'm sure there's a linter somewhere in golangci-lint that should warn about these)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.