Add support for security opts on containers #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once, a long long time ago, we had aspirations of including a more structured way to handle security permissions in Swarmkit. Unfortunately, this never panned out. Rather than continuing to stagnate on a might-be, this change simply add in support for the --security-opt flag and its API equivalents directly. Perfect shouldn't be the enemy of good enough. Signed-off-by: Drew Erny <derny@mirantis.com>
Codecov Report
@@ Coverage Diff @@
## master #3149 +/- ##
==========================================
- Coverage 61.75% 61.71% -0.04%
==========================================
Files 155 155
Lines 31145 31145
==========================================
- Hits 19234 19222 -12
- Misses 10361 10384 +23
+ Partials 1550 1539 -11 |
|
looks related to @dperny are there changes needed on the moby side to punch this through? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Once, a long long time ago, we had aspirations of including a more structured way to handle security permissions in Swarmkit.
Unfortunately, this never panned out. Rather than continuing to stagnate on a might-be, this change simply add in support for the --security-opt flag and its API equivalents directly. Perfect shouldn't be the enemy of good enough.
- How I did it
Adds a
security_optfield to the protobuf definition of ContainerSpec. There aren't actually any other changes needed in Swarmkit. This field will get passed into Swarmkit, then passed from Swarmkit to the executor (which lives in the engine). Swarmkit never needs to care about it.- How to test it
Not needed.