manager/allocator: lift portAllocator out of package cnmallocator
#3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corhere
force-pushed
the
lift-portallocator
branch
2 times, most recently
from
d0a1c5e
to
38585b4
Compare
Replicate the port allocation-related tests from the CNM network allocator's test corpus in preparation for lifting port allocation into allocator.Allocator. Signed-off-by: Cory Snider <csnider@mirantis.com>
The portAllocator constructor function newPortAllocator() takes no arguments; all its initial state is taken from hardcoded constants in the source code. Any failure to construct a port allocator must therefore be the result of a bug in the code, which can only be fixed with a code change. As there is nothing the caller can do at runtime to cause the failure, there is little value in returning the error to the caller. Change the constructor to panic on failure instead. Signed-off-by: Cory Snider <csnider@mirantis.com>
The port allocation logic does not depend on the network allocator implementation in any meaningful way. It has no knowledge of the CNM network allocator's state, and it does not need to change if the network allocator changes. Allocating node ports is fundamentally a seaparate concern from allocating network resources for services and tasks. Therefore the low-level network allocator should not be responsible for allocating both. Lift the port allocator into the Allocator's network context as a sibling of the low-level network allocator. Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
lift-portallocator
branch
from
38585b4
to
6531bf8
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3168 +/- ##
==========================================
- Coverage 61.75% 61.63% -0.12%
==========================================
Files 155 155
Lines 31143 31144 +1
==========================================
- Hits 19232 19197 -35
- Misses 10371 10399 +28
- Partials 1540 1548 +8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Lifted
portAllocatorinto theallocatorpackage fromcnmallocatorto separate the concerns- How I did it
By shuffling code around
- How to test it
CI
- Description for the changelog
N/A; refactor of unexported code