internal/idm: drop libnetwork dependency #3169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
==========================================
- Coverage 55.74% 55.74% -0.01%
==========================================
Files 158 158
Lines 33196 33206 +10
==========================================
+ Hits 18506 18510 +4
- Misses 13228 13236 +8
+ Partials 1462 1460 -2 |
|
There is a minor conflict in this PR. |
Rewrite it in terms of github.com/bits-and-blooms/bitset, an uncompressed bitset data structure. It is only used by portallocator, which requires a maximum set length of 65535, so using compressed bitmaps would be a premature optimization. Signed-off-by: Cory Snider <csnider@mirantis.com>
|
Git was able to rebase automatically 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Modified the internal/idm package to stop depending on package github.com/docker/docker/libnetwork/bitmap.
- How I did it
Rewrite it in terms of github.com/bits-and-blooms/bitset, an uncompressed bitset data structure. It is only used by portallocator, which requires a maximum set length of 65535, so using compressed bitmaps would be a premature optimization.
- How to test it
CI
- Description for the changelog
N/A; internal package