ci: add go 1.18, drop 1.16 #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhgm, golangci-lint does not support go 1.18 yet (golangci/golangci-lint#2374). |
kolyshkin
force-pushed
the
go1.18rc
branch
3 times, most recently
from
4b6a4d7
to
6d79eed
Compare
|
Looks good; do you want to merge it already, or shall we wait for it to be GA, then merge this? (we verified it works) |
Good question. Given there won't be any new PRs between now and 1.18 GA (which is highly likely), we can wait until GA. |
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
OK, we can now test with Go 1.18 (and drop Go 1.16, too). |
|
@thaJeztah PTAL 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.