mountinfo: fix not showing package doc, typos #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Nothing from the doc.go was shown by godoc -- this is because the comment about the package as a whole should precede the "package $NAME", and this was broken here because of an empty line. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
thaJeztah
approved these changes
Sep 23, 2020
| @@ -173,7 +173,7 @@ func unescape(path string) (string, error) { | |||
| } | |||
|
|
|||
| // The following code is UTF-8 transparent as it only looks for some | |||
| // specific characters (backslach and 0..7) with values < utf8.RuneSelf, | |||
| // specific characters (backslash and 0..7) with values < utf8.RuneSelf, | |||
There was a problem hiding this comment.
should we enable misspell in golang-ci-lint? https://golangci-lint.run/usage/linters/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.